Jump to content

[Feature] Make unhooking LG close client


Recommended Posts

Made this on Nullable's request just to remind him

image.png.f96f9823e1642b90c8f2d614102ea1ef.png

The idea behind this is to make TriBot close client it used to hook LG into when TriBot client is asked to close. This means that when using TriBot LG and closing TriBot the client which it hooked into would close a together with it.

Why this might be useful - when using GCS or anything else to semi-automate or fully automate the hooked LG client could be closed automatically just to make it possible to save manual labor and save resources which non-closed LG hooked clients would use.

How to possibly make it - BEFORE YOU BLAME ME ON STUPID THEORY PLEASE UNDERSTAND THAT I DON'T KNOW HOW IT ALL WORKS BEHIND THE CURTAIN - make TriBot fetch LG client process ID and kill it on closing TriBot.

Possible solution - Make TriBot expose process ID of the connected LG client or something to make scripters able to implement such feature in their own scripts. For example Naton would be able to fetch LG hooked client process ID and make GCS close TriBot together with LG client.

Expected solution - Add an option to select in TriBot client settings to close or not close LG client together with TriBot client so people would be able to chose.

  • thonking 1
Link to post
Share on other sites

This would be a cool feature - I've gotten a lot of requests for this over time in my graphical client starter.

 

I think this would be best implemented as a tribot setting along the lines of "Close attached looking glass client when tribot client is closed"

Implementation could be something along the lines of

// Run when adding a looking glass client tab
Runtime.getRuntime().addShutdownHook(new Thread(() -> {
	if (isShutdownLgClientOnClose) {
		ProcessHandle.of(lookingGlassPid).ifPresent(ProcessHandle::destroy);
	}
}));

 

Edited by Naton
  • Like 2
Link to post
Share on other sites
Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Our picks

    • What to expect from TRiBot moving forward.
        • Thanks
        • Like
      • 10 replies
    • TRiBot 12 Release Candidate

      The TRiBot team has been hard at work creating the last major version of TRiBot before the TRiBot X release. We've noticed many problems with TRiBot 11 with a lot of users preferring TRiBot 10 over 11. We've heard you, so we took TRiBot 10, added the new features introduced with 11, introduced some other new things, and created TRiBot 12. So without further adieu, here's TRiBot 12.
        • Sad
        • Like
      • 39 replies
    • Gradle is a build tool used to accelerate developer productivity.

      We recently setup a Maven repository (TRiBot Central) to make it easier for scripters to create scripts. Check it out here: https://gitlab.com/trilez-software/tribot/tribot-central/-/packages

      Furthermore, we've released a simple Gradle project to make it easy to run TRiBot and develop scripts for it. Check it out here: https://gitlab.com/trilez-software/tribot/tribot-gradle-launcher

      The goals of TRiBot Central are to:

      Deliver updates to TRiBot faster


      Better organize TRiBot's dependencies (AKA dependancies)


      Make it easier to develop scripts for TRiBot


      Make it easier to use and run TRiBot


      Note: TRiBot won't be able to run scripts from within this project until TRiBot's next release.
        • Like
      • 13 replies
    • Hi everyone,

      I'd like to thank everyone for their patience in this transition period. Since last week, we've worked out the remaining bugs with this integration.

      Some users have still been having issues with connecting their forums account to their Auth0 account. To resolve this, we've imported all forums accounts into Auth0.

      Unfortunately, the accounts which were imported today were using an unsupported password hashing algorithm. Hence, random passwords were set during the import.

      What does this mean for me?

      If you've previously linked your forums account to your Auth0 account, you don't have to do anything. Nothing changes for you.


      If you haven't logged in via our new login yet,

      Try logging in with your forums email address and the last password you used


      If you are unable to login, please use the "Forgot password" tool on the login page:
      Follow the instructions to reset your password
       
        • thonking
        • Like
      • 17 replies
    • Hello everyone,

      Last week we tried to roll out Auth0 Login, but we lost that battle. Now it's time to win the war!

      Important changes

      When logging into the client, you'll now have to enter your Auth0 account credentials instead of your forums credentials

      Note: 2FA is still handled through your forums account (for the time being)



      Changes for existing users

      You'll have to link your Auth0 account to your forums account here: https://tribot.org/forums/settings/login/?service=11


      Auth0 accounts have been created for most existing users. Please use your forums email address and password to login.



      Important notes

      Make sure to verify your email address upon creating a new Auth0 account


      When we mention your Auth0 account, we mean your account used for auth.tribot.org as displayed below
      • 81 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...