Jump to content

Polymorphic's Scripter Application


Recommended Posts

Monday,
November 22, 2021

Snippets: N/A

Tutorials:

Open source scripts:

1) https://github.com/its-jackson/PolymorphicTreesMaven (Source)
   

2) https://github.com/its-jackson/MotherlodeMineX (Source)
   

3) https://github.com/its-jackson/FletchingX (Source)
   

Short biography / Coding experience:

Hello, my name is Jackson, I'm from Canada and I started to learn programming approximately 2 years ago.

When I was a kid, my brother and I played Runescape. One day we discovered botting, and that's when I acquired my taste for coding.

I decided to enroll into a community college to learn programming. Even though it was a community college and not a fancy university, I struck gold with amazing professors and classmates from all over the world.

Once I finish my 3 years of college, I plan on enrolling into a university afterwards. I study everyday and code everyday, trying to become the programmer I want to be.

Reasons why you feel you deserve Scripter:

The requirements state that you must have adequate Java knowledge. In addition, there is a set of knowledge requirements that must be satisfied. I’d like to think that most exceptions are handled in my scripts and demonstrate adequate Java knowledge. Although my scripts aren't perfect and do have hard-coded methods. My scripts are almost bug free and functional. Additionally, I aim to fix all bugs as soon as they’re reported. 

Two of my scripts follow the big four in OOP, that is abstraction, encapsulation, inheritance, and polymorphism. Demonstrating my knowledge of OOP concepts.

There are a few things that should be changed such as over using Daxwalker. 
I don't have enough users that show any significance. In the future and with bigger scripts, I most defiantly won’t use global walking for a tree < 5 tiles away from the player.

What you plan to provide the community with:

My mission is to provide the community with outstanding support in terms of encouragement, education, and high-quality scripts.

I take pride in helping others, I've always tried my best to encourage fellow classmates to achieve their goals. In addition, I’ve always pushed them to reach their actual capabilities. I want to write more tutorials as I continue my journey throughout school. I will most certainly write tutorials on what I've learned that can be applied to scripting to help others. Lastly, I will write high quality open-source scripts for all users of TRiBot. I will always continue to update and create free scripts.

Do you agree to continue to not only update, but provide more free, open sourced scripts to the community?

Yes.
 

  • Like 4
Link to post
Share on other sites

Code looks neat and has lots of comments. 

B3ffcPL.png

The handleWork method in your motherlode script has 3 nested while loops. People seem to get upset over while loops so it might be too much. It also looks like you have a lot of "framework code" in the main class. If you're sticking with this framework I would turn more of it into an api. 
https://github.com/its-jackson/MotherlodeMineX/blob/5e9db6b96e5cd5d06a68eb4a67d7faa79242de90/src/main/java/scripts/MotherlodeMineX.java#L269

The new sdk has the login handler disabled by default to reduce the amount of threads running. Since you already check if you're logged in in your main loop I would also handle logging in based on this result instead of enabling the login handler and waiting for that to kick in.

You don't always follow naming conventions (although this is scary for me to say since I'm also not the best at it). Final variables should all be uppercase.
https://github.com/its-jackson/MotherlodeMineX/blob/5e9db6b96e5cd5d06a68eb4a67d7faa79242de90/src/main/java/scripts/MotherlodeMineX.java#L156

You don't have to include the no arguments constructor if you're not using it.
https://github.com/its-jackson/FletchingX/blob/c1f9a12f41d6df68dcc257990d8eea861a39d8ea/src/main/java/scripts/api/nodes/RetrieveKnifeFromLumbridgeBasement.java#L26

Imo you're overdoing it a bit with the amount of methods. You have a inventoryContainsKnife method that uses your findInventoryKnife method that uses a findInventoryItem method to do something that's already in the sdk. 

Also your entire execute method here could be replaced with one stream.
https://github.com/its-jackson/FletchingX/blob/c1f9a12f41d6df68dcc257990d8eea861a39d8ea/src/main/java/scripts/api/nodes/RetrieveKnifeFromLumbridgeBasement.java#L30

Your guis look great and the scripts easily meet the minimum complexity level required.

You've shown an interest in really learning java, not just making things work. Most of the things I mentioned are just small nitpicky things I could also encounter in my own code. From me it's a yes.

  • Like 3
Link to post
Share on other sites

I'm a fresher so I don't think it's very appropriate for me to vote - but I will say you are dedicated and a really positive contributer to the tribot community, you're always helpful and extremely friendly. I had a quick look at your code and it's not hard to tell that you care a lot about putting out quality content. 

Best of luck!

  • Like 2
Link to post
Share on other sites
Guest
This topic is now closed to further replies.
  • Our picks

    • We've heard your complaints - the TRiBot API could be much easier to use. We've been dedicating our time to improving the scripter experience here and spent the past year working on a new and improved API - the TRiBot Script SDK.

       

      The TRiBot Script SDK is an easy-to-use library for building TRiBot scripts. It is the recommended approach to building scripts moving forward over the old TRiBot API. It contains all the core things you need to build a script, and a ton of additional helpful stuff to get you using your scripts quicker. See the documentation section for everything offered, and check out the brief overview link too.

       

      The SDK was announced in preview here:

       

      It is now officially released. The official release guarantees we will support backwards compatibility for some period of time. See the 'backwards compatibility' section below for more info.

       

      How to use:

      There is multiple options, listed in the order they are recommended.

      1) Use the gradle template mentioned below

      2) Obtain through gradle

      Add this dependency: api("org.tribot:tribot-script-sdk:+")

      Add this repository: maven("https://gitlab.com/api/v4/projects/20741387/packages/maven")

      3) Take from your local filesystem in your .tribot/install folder. For example, on windows, you'd find it at "C:\Users\[user]\AppData\Roaming\.tribot\install\tribot-client\lib\tribot-script-sdk-[version].jar"

       

      Documentation:

      Java docs: https://runeautomation.com/docs/sdk/javadocs/index.html?overview-summary.html

      Kotlin docs: https://runeautomation.com/docs/sdk/kdocs/index.html

       

      Backwards compatibility:

      We will be following a deprecation schedule whenever we perform a possible breaking change. We will deprecate the respective methods or classes and announce it in a topic. It will remain deprecated for some period of time (weeks or months), and then removed. This will give you time to fix anything, if we need to make a breaking change.

       

      Gradle template:

      Easily build scripts with a new pre-configured scripting gradle template

       

      Users of the current API:

      There is no plans to remove TRiBot API. It will still be available. However, non-critical bugs probably won't be fixed. The SDK does depend on some of the API so fixing some things in the SDK will indirectly fix the API. However, bugs that have existed in the API for awhile will likely not be fixed. It's recommended to use the SDK moving forward. Let us know if there's something the SDK is missing.

       

      Brief overview of the changes:

       

      Bug reports:

      Post bug reports in the bug reports section of the forums

       

       

      Let us know what your thoughts are! If you have questions, feel free to ask below or in discord.

       
        • Like
      • 0 replies
    • Support for the gradle launcher is being dropped. Read more about the new launcher here.
        • Like
      • 8 replies
    • What to expect from TRiBot moving forward.
        • Thanks
        • Like
      • 11 replies
    • TRiBot 12 Release Candidate

      The TRiBot team has been hard at work creating the last major version of TRiBot before the TRiBot X release. We've noticed many problems with TRiBot 11 with a lot of users preferring TRiBot 10 over 11. We've heard you, so we took TRiBot 10, added the new features introduced with 11, introduced some other new things, and created TRiBot 12. So without further adieu, here's TRiBot 12.
        • Sad
        • Like
      • 40 replies
    • Gradle is a build tool used to accelerate developer productivity.

      We recently setup a Maven repository (TRiBot Central) to make it easier for scripters to create scripts. Check it out here: https://gitlab.com/trilez-software/tribot/tribot-central/-/packages

      Furthermore, we've released a simple Gradle project to make it easy to run TRiBot and develop scripts for it. Check it out here: https://gitlab.com/trilez-software/tribot/tribot-gradle-launcher

      The goals of TRiBot Central are to:

      Deliver updates to TRiBot faster


      Better organize TRiBot's dependencies (AKA dependancies)


      Make it easier to develop scripts for TRiBot


      Make it easier to use and run TRiBot


      Note: TRiBot won't be able to run scripts from within this project until TRiBot's next release.
        • Like
      • 13 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...