Jump to content

bill's Scripter Application


Recommended Posts

Open source scripts available to the public:

  https://github.com/billV587/ERNEST_THE_CHICKEN

Script introduction; No requirements, and you get 5 quest points quickly. All you have to do is click on a start script. Perfect Ernest the Chicken.

https://github.com/billV587/ROMEO__JULIET

Script introduction;No requirements, and you get 5 quest points quickly. All you have to do is click on a start script. Perfect Romeo & Juliet.

https://github.com/billV587/NATURE_SPIRIT

Script introduction; Get 200k gold and click Start anywhere.Attack 30 Strength 30 Defence 30 Prepare 200K gold, click anywhere to start. Complete the Nature Spirit mission perfectly. (Must complete The prerequisite mission of Nature Spirit, The Restless Ghost Priest in Peril) Complete the Nature Spirit mission perfectly.

Short biography / Coding Experience: 

I am a programmer myself with 5 years of Java programming experience. Two years ago I started trying to write small scripts for my own use. I love the Tribot platform. Now I'd like to share these scripts with you. I hope to study with you and make progress together!

Reasons why you feel you deserve Scripter:

I am a big fan of RS. And he has a small gold mining studio. I know exactly what players and gold mining studios are looking for. I am confident that more people will like my script

What you plan to provide the community with:

I know every nook and cranny of the game, every play. I'm working on developing more free scripts that allow robots to replace boring, monotonous actions. Make the game fun. Get more users to the Tribot

Do you agree to continue to not only update, but provide more free, open sourced scripts to the community?

Yes

Edited by 56669179
  • thonking 1
Link to post
Share on other sites

I'm not going to go into full detail of checking your code but a couple of things:

  • All scripts being applied with must have been uploaded to the repository more than 30 days from applying

This is one critical condition outlined in the requirements that is not met, I believe you've just posted the repo's for each of your scripts but have not uploaded them to the repo.

The main idea behind this requirement is to get a few users using your script and to see how you go with supporting them, so might be an idea to setup threads for these scripts and getting them uploaded on the repo :)

A second point, you've got a fairly convoluted "pyramid" of if's and else if's in at least 2/3 of the scripts (I didn't check all of them).

I believe your scripts are at a complexity level where it would definitely be more suited to a framework for making it easier to understand for people reviewing, and ultimately for yourself when giving support to users through bug fixes.

As you've mentioned you've been coding with Java for 5 years so I think you could appreciate your code should be easy to read.

Cheers! 

Link to post
Share on other sites

As Nick has said, your scripts need to be on the repository for a minimum of 30 days before applying. Could you upload them & make threads for each with details on how users can run etc? If you need help on doing so, feel free to give me a PM.

As for your code, In the next 30 days I'd look at making it as readable as possible for someone that has never run / seen the design of the script and doesn't know much about RS. Your use of random naming + ids makes it impossible for someone to understand what is going on.

An example might be your pull method in the Ernest the Chicken script. What are we pulling? Why are we pulling it? What object are we interacting with etc.

private void pull() {
  // what lever are we pulling, what is id 123? etc.
  Object.interact(123, "Pull");
}

vs making a Lever object and interacting with it

private boolean pullLever(Lever lever) {
  if (lever == null) {
    // we can report there's no valid lever
    return;
  }
  
  // we're going to pull our lever as it exists
  return lever.interact("Pull"); // return a boolean if we interacted with the lever successfully
}

By amending our naming / use of objects slightly, it can be easier to follow and thus easier for other scripters reviewing your application to get a greater understanding of what you're trying to do.

I'll close this application pending the 30 day duration of your scripts on the repo. Feel free to PM me after 30 days to re-open it, or you can re-apply with cleaner code, whichever you prefer. :)

Edited by Jamie
  • Like 2
Link to post
Share on other sites
  • Jamie locked this topic
Guest
This topic is now closed to further replies.
  • Our picks

    • We've heard your complaints - the TRiBot API could be much easier to use. We've been dedicating our time to improving the scripter experience here and spent the past year working on a new and improved API - the TRiBot Script SDK.

       

      The TRiBot Script SDK is an easy-to-use library for building TRiBot scripts. It is the recommended approach to building scripts moving forward over the old TRiBot API. It contains all the core things you need to build a script, and a ton of additional helpful stuff to get you using your scripts quicker. See the documentation section for everything offered, and check out the brief overview link too.

       

      The SDK was announced in preview here:

       

      It is now officially released. The official release guarantees we will support backwards compatibility for some period of time. See the 'backwards compatibility' section below for more info.

       

      How to use:

      There is multiple options, listed in the order they are recommended.

      1) Use the gradle template mentioned below

      2) Obtain through gradle

      Add this dependency: api("org.tribot:tribot-script-sdk:+")

      Add this repository: maven("https://gitlab.com/api/v4/projects/20741387/packages/maven")

      3) Take from your local filesystem in your .tribot/install folder. For example, on windows, you'd find it at "C:\Users\[user]\AppData\Roaming\.tribot\install\tribot-client\lib\tribot-script-sdk-[version].jar"

       

      Documentation:

      Java docs: https://runeautomation.com/docs/sdk/javadocs/index.html?overview-summary.html

      Kotlin docs: https://runeautomation.com/docs/sdk/kdocs/index.html

       

      Backwards compatibility:

      We will be following a deprecation schedule whenever we perform a possible breaking change. We will deprecate the respective methods or classes and announce it in a topic. It will remain deprecated for some period of time (weeks or months), and then removed. This will give you time to fix anything, if we need to make a breaking change.

       

      Gradle template:

      Easily build scripts with a new pre-configured scripting gradle template

       

      Users of the current API:

      There is no plans to remove TRiBot API. It will still be available. However, non-critical bugs probably won't be fixed. The SDK does depend on some of the API so fixing some things in the SDK will indirectly fix the API. However, bugs that have existed in the API for awhile will likely not be fixed. It's recommended to use the SDK moving forward. Let us know if there's something the SDK is missing.

       

      Brief overview of the changes:

       

      Bug reports:

      Post bug reports in the bug reports section of the forums

       

       

      Let us know what your thoughts are! If you have questions, feel free to ask below or in discord.

       
        • Like
      • 0 replies
    • Support for the gradle launcher is being dropped. Read more about the new launcher here.
        • Like
      • 8 replies
    • What to expect from TRiBot moving forward.
        • Thanks
        • Like
      • 11 replies
    • TRiBot 12 Release Candidate

      The TRiBot team has been hard at work creating the last major version of TRiBot before the TRiBot X release. We've noticed many problems with TRiBot 11 with a lot of users preferring TRiBot 10 over 11. We've heard you, so we took TRiBot 10, added the new features introduced with 11, introduced some other new things, and created TRiBot 12. So without further adieu, here's TRiBot 12.
        • Sad
        • Like
      • 40 replies
    • Gradle is a build tool used to accelerate developer productivity.

      We recently setup a Maven repository (TRiBot Central) to make it easier for scripters to create scripts. Check it out here: https://gitlab.com/trilez-software/tribot/tribot-central/-/packages

      Furthermore, we've released a simple Gradle project to make it easy to run TRiBot and develop scripts for it. Check it out here: https://gitlab.com/trilez-software/tribot/tribot-gradle-launcher

      The goals of TRiBot Central are to:

      Deliver updates to TRiBot faster


      Better organize TRiBot's dependencies (AKA dependancies)


      Make it easier to develop scripts for TRiBot


      Make it easier to use and run TRiBot


      Note: TRiBot won't be able to run scripts from within this project until TRiBot's next release.
        • Like
      • 15 replies
  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...