Listing all worlds without the world list loaded in the client results in tribot making request to jagex every time

[Naton 1028]

Looks like tribot actually makes a call to download the world list every time, even if it's already cached the worlds. This results in a massive amount of requests.

 

For example, run the following script

		super.setLoginBotState(false);
		long l = Timing.currentTimeMillis();
		WorldHopper.getServers();
		println(Timing.timeFromMark(l));
		WorldHopper.getServers();
		println(Timing.timeFromMark(l));
		WorldHopper.getServers();
		println(Timing.timeFromMark(l));

Gives

• [19:45:18] Script Started: Test.
• [19:45:18] 145
• [19:45:18] 230
• [19:45:18] 327

 

Showing that its taking a large amount of time, so it's clearly downloading the world list. If you open the world list in-game, it gives:

• [19:51:10] Script Started: Test.
• [19:51:10] 3
• [19:51:10] 3
• [19:51:10] 4

 

It's unnecessary to make a request every time, and adds a massive amount of time/load. It could be a flag as well since it downloads from the official runescape website. Realistically, if the world list has already been downloaded once, just continue to use that. Could add a time check to invalidate if necessary. Otherwise every Query.worlds() will always make a network request.

[SkrrtNick 236]

Opened a PR that aims to resolve this 🙂